Bump Ruma (breaking) #5337
Open
Bump Ruma (breaking) #5337
+624
−695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 3, 2025
Merged
zecakeh
force-pushed
the
event-handler-type-prefix
branch
from
9730498 to
d05861b
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #5337 +/- ##
==========================================
+ Coverage 88.85% 88.89% +0.03%
==========================================
Files 333 333
Lines 91234 91112 -122
Branches 91234 91112 -122
==========================================
- Hits 81066 80991 -75
+ Misses 6346 6301 -45
+ Partials 3822 3820 -2 ☔ View full report in Codecov by Sentry. |
zecakeh
force-pushed
the
event-handler-type-prefix
branch
from
d05861b to
dc253ad
Compare
jplatte
reviewed
Jul 8, 2025
zecakeh
force-pushed
the
event-handler-type-prefix
branch
from
dc253ad to
8423330
Compare
jplatte
reviewed
Jul 13, 2025
| None, | ||
| rendezvous_server.to_string(), | ||
| None, | ||
| &SupportedVersions { versions: Default::default(), features: Default::default() }, |
There was a problem hiding this comment.
Should we have an associated const for empty SupportedVersions upstream?
There was a problem hiding this comment.
In this case, it looks to me like we should call /versions first, otherwise when this becomes stable we won't know which version of the path to call.
zecakeh
force-pushed
the
event-handler-type-prefix
branch
from
8423330 to
93e2549
Compare
|
I think you can rebase with |
zecakeh
force-pushed
the
event-handler-type-prefix
branch
from
93e2549 to
6976df0
Compare
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
zecakeh
force-pushed
the
event-handler-type-prefix
branch
from
6976df0 to
513eba6
Compare
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
…oints Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
zecakeh
force-pushed
the
event-handler-type-prefix
branch
from
513eba6 to
68bbd48
Compare
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is
more or lessready, with all the changes that are required due to breaking changes in Ruma.I still need to fix a few tests. I will probably open other PRs soon to try to make this slightly smaller (but there is not much to do).I tried to split the commits by source of the change, so I recommend to review this commit by commit. However after the first commit the code doesn't compile unless all the other commits are applied, so I recommend to squash everything when merging.
Note that currently Ruma is not ready for a release with those breaking changes, however it should be ready in a few weeks.Ruma should be ready for release when the support for room version 12 is added in the next few days.This is supposed to be part of 3 PRs: